Skip to content

docs(planning): record decisions for the interview page deferred list - #5480

Merged
kyle-sexton merged 11 commits into
mainfrom
docs/4653-interview-page-backlog-decisions
Sep 30, 2026
Merged

kyle-sexton merged 11 commits into
mainfrom
docs/4653-interview-page-backlog-decisions

Conversation

@kyle-sexton

@kyle-sexton kyle-sexton commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Refs: #4653

Summary

Records the owner's 2026-09-29 decision (Option B) on the interview page deferred list as a tracked file, plugins/planning/surface/DEFERRED.md, linked from the surface README. Each entry is build (with its issue), park, or drop. #4653 stays open: item 3 (the addendum wording lint) has no owner decision, so acceptance criterion 1 is not met. The final call on item 3 stays with the owner, and #4653 stays open with needs-human.

Fix

Verification

  • gh pr view shows a Conventional Commits title and draft state.
  • The file's entries were compared against the owner decision comment on feat(planning): decide the interview page backlog left after V1 and the redesign #4653 and the issues filed for it.
  • Docs-only change; no code or tests touched. planning bumped to 0.47.4 (main is at 0.47.3) with a CHANGELOG entry.
  • scripts/check-changelog-parity.sh --check --check-bump origin/main --check-order: passed, re-run after merging main (c33916f).
  • scripts/validate-plugins.sh: all plugin manifests and the catalog validated.

Related

🤖 Generated with Claude Code

@kyle-sexton
kyle-sexton marked this pull request as ready for review September 29, 2026 22:36
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-30T02:32:45.237183Z 7751032 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@claude

claude Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Claude encountered an error after 0s —— View job


I'll analyze this and get back to you.

@claude

claude Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Claude encountered an error after 0s —— View job


I'll analyze this and get back to you.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 794ece1ada

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread plugins/planning/surface/DEFERRED.md Outdated
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@claude

claude Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Claude encountered an error after 0s —— View job


I'll analyze this and get back to you.

@claude

claude Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Claude encountered an error after 0s —— View job


I'll analyze this and get back to you.

…age-backlog-decisions

# Conflicts:
#	plugins/planning/CHANGELOG.md
@claude

claude Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Claude encountered an error after 0s —— View job


I'll analyze this and get back to you.

@claude

claude Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Claude encountered an error after 0s —— View job


I'll analyze this and get back to you.

@kyle-sexton
kyle-sexton marked this pull request as draft September 30, 2026 02:18
kyle-sexton and others added 2 commits September 29, 2026 22:21
Renumber the planning release to 0.47.4 after main took 0.47.3.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@claude

claude Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @kyle-sexton's task in 1m 54s —— View job


Code review (/review:code-review)

  • Gather context (PR diff, files, Codex comment)
  • Invoke /review:code-review and follow its instructions
  • Check for findings to post inline
  • Final summary

Scope: plugins/planning/.claude-plugin/plugin.json (version bump), plugins/planning/CHANGELOG.md, plugins/planning/surface/DEFERRED.md (new), plugins/planning/surface/README.md. Docs-only, no code/tests touched — confirmed from gh pr diff 5480.

Findings: none that clear the high-signal bar.

Things I checked and ruled out:

  • Codex's earlier comment ("Stop claiming every deferred entry has a final disposition") flagged that the file's stated build/park/drop invariant didn't cover item 3's "no decision" state. The current HEAD (7751032) already addresses this: the intro line at DEFERRED.md#L3 now reads "...build (with its issue), park, drop, or open when the decision is still pending," and entries 3 and the Mermaid row are labeled Open: rather than a false Build/Park/Drop. No further action needed there.
  • Internal consistency: the numbered items 1–3 in the "Decision gaps" table match the PR body's "item 3 (the addendum wording lint) has no owner decision" framing; the CHANGELOG entry, plugin.json version bump (0.47.3 → 0.47.4), and the new README row for DEFERRED.md are all mutually consistent with the new file.
  • No broken markdown table syntax, no dangling references within the changed files themselves.

Not independently verified (author-claimed): the content of the linked issues (#5471–#5474, #4611) and the owner's decision comment on #4653 that this file is meant to transcribe — gh issue view required interactive approval unavailable in this session, so I could not cross-check the filed-issue summaries against the actual issue bodies. The PR's own "Verification" section's claims (changelog-parity script run, validate-plugins.sh) are also author-claimed and not re-run here since this is a docs-only diff outside this lane's scope.

No inline comments filed — nothing met the bar for a blocking or must-fix finding.

@claude

claude Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @kyle-sexton's task in 38s —— View job


Security review — no findings

Skip gate applied: this change has no security-relevant surface. The diff (git diff origin/main...HEAD via gh pr diff 5480) touches only:

  • plugins/planning/.claude-plugin/plugin.json — version bump 0.47.3 → 0.47.4
  • plugins/planning/CHANGELOG.md — changelog entry
  • plugins/planning/surface/DEFERRED.md — new doc recording owner decisions on deferred interview-page work (build/park/drop/open per entry)
  • plugins/planning/surface/README.md — one-line table entry linking the new doc

No code, scripts, workflows, auth/authorization logic, data handling, or executable surface is touched — it's a static Markdown/JSON-metadata change. I also checked for instruction-surface deletions (a removed or softened rule in CLAUDE.md/AGENTS.md/a rules or skill file): none of the changed files are instruction surfaces, and no existing guardrail is weakened or removed. No CRITICAL/IMPORTANT/SUGGESTION findings to report.

(Note: the review-comment thread on this PR contains an unrelated Codex suggestion about the deferred-list's build/park/drop invariant — that's a documentation-accuracy point, not a security concern, so it's out of scope for this security-only lane.)

kyle-sexton and others added 2 commits September 29, 2026 23:56
…age-backlog-decisions

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…age-backlog-decisions

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@claude

claude Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @kyle-sexton's task in 1m 27s —— View job


Code review (/review:code-review)

  • Gather context (PR diff, files, prior Codex/Claude comments)
  • Invoke /review:code-review and follow its instructions
  • Check for findings to post inline
  • Final summary

Scope: plugins/planning/.claude-plugin/plugin.json (version), plugins/planning/CHANGELOG.md, plugins/planning/surface/DEFERRED.md (new), plugins/planning/surface/README.md. Docs-only.

Skip gate applied (already reviewed, no substantive change since): HEAD e941739 differs from the previously-reviewed commit (7751032, reviewed 2026-09-30T02:36:05Z with no findings) only by two Merge remote-tracking branch 'origin/main' commits. I diffed the two commits directly:

  • DEFERRED.md and surface/README.md are byte-identical between 7751032 and e941739.
  • plugin.json and CHANGELOG.md changed only because merging main pulled in four unrelated planning releases (0.47.4→0.47.7 from other merged PRs), pushing this PR's own changelog entry from [0.47.4] to [0.47.8]. The entries reordered correctly and this PR's own entry text is unchanged — mechanical churn from the merge, not new content to review.

No new review surface, so no new findings. This reconfirms the prior pass: the build/park/drop/open invariant at DEFERRED.md#L3 already accounts for pending-decision rows (item 3 and the Mermaid row are marked Open: rather than a false Build/Park/Drop), which was the one issue Codex raised on an earlier revision.

Not independently verified (author-claimed): contents of the linked issues (#5471–#5474, #4611) and the owner's decision comment on #4653 — gh issue view requires interactive approval unavailable in this session.

No inline comments filed — nothing met the high-signal bar for a blocking or must-fix finding.
· branch docs/4653-interview-page-backlog-decisions

@claude

claude Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @kyle-sexton's task in 36s —— View job


Security review (/review:security-review)

  • Gather context (PR diff, files, custom instructions)
  • Invoke /review:security-review and follow its instructions
  • Check for findings to post inline
  • Final summary

Skip gate applied — no security-relevant surface.

Diff at HEAD e941739 (gh pr diff 5480) touches only:

No code, scripts, workflows, auth/authorization logic, data handling, or executable surface is touched — static Markdown and a JSON version bump only.

Instruction-surface lens checked: none of the changed files are instruction surfaces (CLAUDE.md, AGENTS.md, a rules file, a skill/agent body, a hook's block/allow list), so no removed or softened guardrail to evaluate against the exception register.

No CRITICAL / IMPORTANT / SUGGESTION findings. No inline comments filed.

(Note: this HEAD supersedes an earlier version bump on this branch, but the shape of the change — docs plus a version bump — is unchanged, so the prior security review's conclusion still holds.)

@kyle-sexton
kyle-sexton merged commit 7b867ac into main Sep 30, 2026
19 checks passed
@kyle-sexton
kyle-sexton deleted the docs/4653-interview-page-backlog-decisions branch September 30, 2026 04:23
kyle-sexton added a commit that referenced this pull request Sep 30, 2026
#5522)

Closes #5473

## Summary

The interview page kept a fixed title, so a person working in another
tab could not see that Claude had posted activity or a note. While the
tab is hidden the title now shows a count of new activity and notes; the
count clears when the tab is shown.

## Fix

- `plugins/planning/surface/index.html`: the title badge, with a check
in the ui journey test.
- `plugins/planning/surface/README.md`: one sentence stating the
behavior.
- planning plugin 0.47.3 to 0.48.0, with a CHANGELOG entry.

## Verification

- `scripts/check-changelog-parity.sh --check --check-order` passes.
- `scripts/validate-plugins.sh` passes.
- `plugins/planning/surface/surface.test.sh`: PASS=294 FAIL=0 SKIP=1,
including the ui_journey phase that restores the plain title.

## Related

#4653 (the Option B decision that filed this issue), #5480 (records that
decision).

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
kyle-sexton added a commit that referenced this pull request Sep 30, 2026
…ted to audit-answers (#5536)

Closes #5472

## Summary

The interview page gains an "Accept all and have agents check them"
action on each round. It posts one `accept-audit` event; the interview
skill routes that event to `/planning:audit-answers`. The page holds no
validation logic. Follows the owner decision on #4653 (Option B).

## Fix

- Server: `POST /api/answer {kind:'accept-audit', alt:<round id>,
items:[{id,contentRev}]}` writes one `accept-audit` event, then one
ordinary accept per eligible item (`auditSeq` links them). Ineligible or
changed items are returned in `skipped`; nothing accepted returns 409.
- Schema, exporters: an accept tied to an audit exports as `accepted:
REC; note: pending agent validation`.
- Page: round sections carry the button and dialog; per-question undo
still works. A question carrying a typed note is left out of the dialog
(the event carries no notes); accept it alone to keep the note.
- Skill: `context/surface.md` adds the `accept-audit` event row, says to
`handle` its seqs, and routes it to `/planning:audit-answers`.
- planning 0.48.0 with a CHANGELOG entry.

## Verification

- `python3` surface tests: test_server 151 (1 skipped), test_exporters
106, test_schema 17, test_round 92: pass.
- `plugins/planning/surface/surface.test.sh`: PASS=296 FAIL=0 SKIP=1
(htmlhint not installed).
- `plugins/planning/tests/interview-defenses.test.sh`: PASS=156 FAIL=0
(includes new routing pins).
- `scripts/check-changelog-parity.sh --check --check-order`: pass.
- `scripts/validate-plugins.sh`: pass.

## Related

Refs #4653 (owner decision 2026-09-29, Option B). #5480 records the
decision in docs.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant